Checkbox

Merge lp://qastaging/~sylvain-pineau/checkbox/providers_new_packaging into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

  1. providers_new_packaging
  2. Merge into checkbox-packaging
Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 42
Merged at revision: 41
Proposed branch: lp://qastaging/~sylvain-pineau/checkbox/providers_new_packaging
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 117 lines (+14/-46)
6 files modified
debian/plainbox-provider-certification-client.install (+2/-3)
debian/plainbox-provider-certification-server-soc.install (+2/-3)
debian/plainbox-provider-certification-server.install (+2/-3)
debian/plainbox-provider-checkbox.install (+2/-5)
debian/plainbox-provider-resource-generic.install (+2/-3)
debian/rules (+4/-29)
To merge this branch: bzr merge lp://qastaging/~sylvain-pineau/checkbox/providers_new_packaging
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Sylvain Pineau (community) Needs Resubmitting
Review via email: mp+195556@code.qastaging.launchpad.net

Description of the change

packaging MR linked to this branch: https://code.launchpad.net/~sylvain-pineau/checkbox/provider_symlinks/+merge/195555

Here we can see the benefit of having setup.py handling all the providers deb layout.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

10:02 zyga: spineau: I love how that makes packaging way easier :D
10:03 zyga: spineau: do we need "50+usr/lib/plainbox-providers-1/plainbox-resources" in .install files? I thought that just having a file path makes it sufficient for the directory to become created
10:03 zyga: spineau: and presumably the 'lib' directory is created by per-provider setup
10:04 zyga: spineau: please add a comment as to why we're removing egg-info's from providers (because they aren't python and we're just cheating to have the install process working)
10:04 zyga: spineau: otherwise packaging is big +1 :)

lp://qastaging/~sylvain-pineau/checkbox/providers_new_packaging updated
41. By Sylvain Pineau

debian:rules: delegate providers deb layout to setuptools

42. By Sylvain Pineau

debian:plainbox-provider*.install: Just use the debian/tmp content as it is

egg-info's are removed from providers install files because they aren't python
We're just cheating to have the install process working.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Added a note explaining why we're not including eggs-info

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

On Mon, Nov 18, 2013 at 10:15 AM, Sylvain Pineau <
<email address hidden>> wrote:

> Review: Resubmit
>
> Added a note explaining why we're not including eggs-info
> --
>
> https://code.launchpad.net/~sylvain-pineau/checkbox/providers_new_packaging/+merge/195556
> Your team Checkbox Developers is subscribed to branch
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>

Revision history for this message
Zygmunt Krynicki (zyga) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches