Merge lp://qastaging/~sylvain-pineau/ubuntu/trusty/plainbox-provider-resource-generic/namespace_fix into lp://qastaging/ubuntu/trusty/plainbox-provider-resource-generic

Proposed by Sylvain Pineau
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp://qastaging/~sylvain-pineau/ubuntu/trusty/plainbox-provider-resource-generic/namespace_fix
Merge into: lp://qastaging/ubuntu/trusty/plainbox-provider-resource-generic
Diff against target: 31 lines (+11/-1)
3 files modified
debian/patches/provider_namespace.patch (+9/-0)
debian/patches/series (+1/-0)
plainbox-resources.provider (+1/-1)
To merge this branch: bzr merge lp://qastaging/~sylvain-pineau/ubuntu/trusty/plainbox-provider-resource-generic/namespace_fix
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Ubuntu Development Team Pending
Review via email: mp+212627@code.qastaging.launchpad.net

Description of the change

Fix the namespace of the provider to comply with checkbox-ng 0.2.2-1 settings (once synced from Debian)

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This looks good and should land. It will also be safe to drop on the next sync from Debian (once we re-release those packages). The problem is caused by hard-coded string in checkbox-ng that looks for '2013.com.canonical.certification' while the older packages still have '2013.com.canonical' (without .certification) and stuff would just crash.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, could you add a changelog entry? If those changes are needed, with the new checkbox, how come checkbox was updated to Debian without those? It would make sense to get that uploaded to Debian and synced if we can...

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

IIRC this is now fixed, this comment is just to explain and answer Sebastien's question. The reason this is not fixed in Debian yet is that we wanted to avoid the round-trip this time (it's really close to 14.04 release) and our next update to Debian will include this fix (already applied in trunk) as well as new features that we want to stabilize first. So yeah, Debian releases are broken but we're working on fixing those as well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches