Do

Merge lp://qastaging/~t-launchpad-zombywuf-org/do/dbus-fixes into lp://qastaging/do

  1. dbus-fixes
  2. Merge into trunk
Proposed by Zombywuf
Status: Rejected
Rejected by: Alex Launi
Proposed branch: lp://qastaging/~t-launchpad-zombywuf-org/do/dbus-fixes
Merge into: lp://qastaging/do
To merge this branch: bzr merge lp://qastaging/~t-launchpad-zombywuf-org/do/dbus-fixes
Reviewer Review Type Date Requested Status
Do Core Team Pending
Review via email: mp+3478@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Zombywuf (t-launchpad-zombywuf-org) wrote :

When do registers itself on dbus it doesn't use RegisterName in the correct way as per the documentation here: http://www.ndesk.org/DBus_Documentation under "Obtaining a bus name". It also fails to release the bus name when it exits, causing do to hang when you try to restart it. This branch fixes these errors.

It also includes a change to Do.Interface.Linux.Docky to change auto generated property getters and setters to manual getters and setters. This is due to the fact it was causing build errors, I suspect they may be due to a bug in the mono compiler.

Revision history for this message
Alex Launi (alexlauni) wrote :

Please submit these in two separate merges. The build failure is not a bug in mono, it's that you're version is old. We don't want to change those.

Unmerged revisions

949. By Zombywuf <zombywuf@zombypad>

Changed autogenerated get set to fix build errors. Possibly working round a bug in mono