Merge lp://qastaging/~taoliu-7/charm-helpers/key into lp://qastaging/charm-helpers
Proposed by
Tony Liu
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~taoliu-7/charm-helpers/key |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
14 lines (+4/-0) 1 file modified
charmhelpers/fetch/__init__.py (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~taoliu-7/charm-helpers/key |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Van Steenburgh | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Add support to get PGP key by HTTP.
This is for using custom secured repo in a private environment.
To post a comment you must log in.
Unmerged revisions
- 435. By Tony Liu
-
Get key by HTTP.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Generally looks fine. I questioned the sanity of downloading the key over http, but I suppose it is no less secure than hkp, which we already support.
A couple of requests though:
- Please add a test for this. Existing tests around this code exist in tests/fetch/
- One comment inline