Merge lp://qastaging/~tealeg/charms/trusty/glance-simplestreams-sync/work-with-multiple-rabbitMQs into lp://qastaging/~landscape/charms/trusty/glance-simplestreams-sync/landscape
Proposed by
Geoff Teale
| Status: | Merged |
|---|---|
| Approved by: | Geoff Teale |
| Approved revision: | 64 |
| Merged at revision: | 61 |
| Proposed branch: | lp://qastaging/~tealeg/charms/trusty/glance-simplestreams-sync/work-with-multiple-rabbitMQs |
| Merge into: | lp://qastaging/~landscape/charms/trusty/glance-simplestreams-sync/landscape |
| Diff against target: |
17 lines (+5/-1) 1 file modified
scripts/glance-simplestreams-sync.py (+5/-1) |
| To merge this branch: | bzr merge lp://qastaging/~tealeg/charms/trusty/glance-simplestreams-sync/work-with-multiple-rabbitMQs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Данило Шеган (community) | Approve | ||
| Alberto Donato (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The charmhelpers library will always set the rabbit_hosts variable to a comma separated string of IP addresses, however the charm expects a python array. This branch produces such an array by splitting the string.
To post a comment you must log in.
Revision history for this message
| Данило Шеган (danilo) wrote | # |
Revision history for this message
| Geoff Teale (tealeg) wrote | # |
Revision history for this message
| Geoff Teale (tealeg) wrote | # |
Revision history for this message
| Данило Шеган (danilo) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, will give it a run over the weekend. I assume I can use cs:~tealeg/