Merge lp://qastaging/~tealeg/landscape-client/mocker-replace-test-fd into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Geoff Teale
Status: Merged
Approved by: Geoff Teale
Approved revision: 854
Merged at revision: 863
Proposed branch: lp://qastaging/~tealeg/landscape-client/mocker-replace-test-fd
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 119 lines (+35/-40)
1 file modified
landscape/lib/tests/test_fd.py (+35/-40)
To merge this branch: bzr merge lp://qastaging/~tealeg/landscape-client/mocker-replace-test-fd
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+297527@code.qastaging.launchpad.net

Commit message

Replace the mocker library with mock in landscape.lib.tests.test_fd

Description of the change

Replace the mocker library with mock in landscape.lib.tests.test_fd

Testing instructions:

make check

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1 with some comments

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 849
Branch: lp:~tealeg/landscape-client/mocker-replace-test-fd
Jenkins: https://ci.lscape.net/job/latch-test/5050/

review: Approve (test results)
850. By Geoff Teale

Inline getrlimit assertions.

851. By Geoff Teale

Simplify patch call.

852. By Geoff Teale

Simplify patch calls.

853. By Geoff Teale

Simplify error throwing side effect.

854. By Geoff Teale

lint

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: