Merge lp://qastaging/~ted/ido/gtest into lp://qastaging/ido/12.10

Proposed by Ted Gould
Status: Merged
Merged at revision: 109
Proposed branch: lp://qastaging/~ted/ido/gtest
Merge into: lp://qastaging/ido/12.10
Diff against target: 303 lines (+232/-1)
7 files modified
.bzrignore (+4/-0)
Makefile.am (+1/-1)
configure.ac (+8/-0)
m4/gtest.m4 (+63/-0)
src/idorange.h (+2/-0)
tests/Makefile.am (+52/-0)
tests/gtest-menuitems.cpp (+102/-0)
To merge this branch: bzr merge lp://qastaging/~ted/ido/gtest
Reviewer Review Type Date Requested Status
jenkins (community) continuous-integration Approve
Charles Kerr (community) Needs Fixing
Review via email: mp+103564@code.qastaging.launchpad.net

Description of the change

Adding the gtest framework and a few tests to make sure our menu items can be created and realized.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

ted, looks like this diff is missing the implementation of CHECK_XORG_GTEST.

Did you mean to bzr add another file into m4/ ?

review: Needs Fixing
Revision history for this message
Charles Kerr (charlesk) wrote :

d'oh, libxorg-gtest-dev

Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:119
http://jenkins.qa.ubuntu.com/job/ido-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-ci/./label=precise/3/console

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

This was merged awhile back in revno: 109, finally closing out the merge requests and marking this as Merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches