Network Menu

Merge lp://qastaging/~ted/indicator-network/upstart-job into lp://qastaging/indicator-network/13.10

  1. upstart-job
  2. Merge into trunk.13.10
Proposed by Ted Gould
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 251
Merged at revision: 243
Proposed branch: lp://qastaging/~ted/indicator-network/upstart-job
Merge into: lp://qastaging/indicator-network/13.10
Prerequisite: lp://qastaging/~ted/indicator-network/indicators-change
Diff against target: 134 lines (+45/-12)
9 files modified
.bzrignore (+1/-0)
data/Makefile.am (+8/-8)
data/com.canonical.indicator.network.service.in (+0/-3)
data/indicator-network.conf.in (+12/-0)
debian/control (+0/-1)
debian/indicator-network-crashdb.conf (+6/-0)
debian/rules (+4/-0)
debian/source_indicator-network.py (+10/-0)
network/network-action-manager.vala (+4/-0)
To merge this branch: bzr merge lp://qastaging/~ted/indicator-network/upstart-job
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+160542@code.qastaging.launchpad.net

Commit message

Move from dbus activation to upstart user session job

Description of the change

The main thrust of this branch is to move to upstart user session. Along the way we drop dbus activation and add an apport hook to pick up the new log file.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:251
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-raring-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-raring-armhf-ci/9

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-network-ci/9/rebuild

review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I understand the usefulness for debugging, but I strongly feel we should avoid having G_MESSAGES_DEBUG set in the upstart job. This is so likely to just get forgotten and left in ;)

No point in spamming .xsession-errors

review: Needs Fixing
Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2013-04-24 at 14:10 +0000, Mathieu Trudel-Lapierre wrote:

> I understand the usefulness for debugging, but I strongly feel we should avoid having G_MESSAGES_DEBUG set in the upstart job. This is so likely to just get forgotten and left in ;)
>
> No point in spamming .xsession-errors

See, and now you see the beauty of upstart user session. It WON'T spam
xsession-errors because it only puts the log from that job in
~�.cache�upstart�indicator-network.log and we can then attach that in
the apport hook. So we can avoid the xession-errors issue *and* get
good bug reports!

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve. Let's keep in mind to fix up the debug logs situation.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches