Merge lp://qastaging/~ted/indicator-session/upower-init-criticals into lp://qastaging/indicator-session/12.10
Proposed by
Ted Gould
| Status: | Merged |
|---|---|
| Approved by: | Charles Kerr |
| Approved revision: | 362 |
| Merged at revision: | 363 |
| Proposed branch: | lp://qastaging/~ted/indicator-session/upower-init-criticals |
| Merge into: | lp://qastaging/indicator-session/12.10 |
| Diff against target: |
22 lines (+5/-1) 1 file modified
src/session-menu-mgr.c (+5/-1) |
| To merge this branch: | bzr merge lp://qastaging/~ted/indicator-session/upower-init-criticals |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
| Lars Karlitski (community) | Approve | ||
| jenkins (community) | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Move UPower settings init until after the items are created
Description of the change
If you're missing hibernate (like I am) and that happens at startup then having this in the _init will mean that you get a bunch of criticals on startup because the menu items aren't actually built yet. Moving it so the visibility is still correct, but the items exist.
To post a comment you must log in.
Revision history for this message
| jenkins (martin-mrazik+qa) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:362
http://
Executed test runs:
FAILURE: http://