Merge lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data into lp://qastaging/indicator-sound/14.10
Proposed by
Ted Gould
| Status: | Superseded | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data | ||||
| Merge into: | lp://qastaging/indicator-sound/14.10 | ||||
| Diff against target: |
359 lines (+131/-42) 9 files modified
data/com.canonical.indicator.sound.gschema.xml (+0/-9) src/CMakeLists.txt (+4/-0) src/accounts-service-privacy-settings.vala (+26/-0) src/accounts-service-user.vala (+32/-2) src/media-player-mpris.vala (+1/-1) src/service.vala (+30/-27) src/sound-menu.vala (+10/-2) src/volume-control.vala (+2/-1) tests/manual (+26/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Antti Kaijanmäki (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-10-31.
Commit message
Ensure the greeter menu matches whether song metadata should be shown, and update the metadata based on the new setting.
Description of the change
Listen to the values in accounts service as it's now where all those values are stored. Changes both exporting the song data to AS as well as how our local instance of the greeter menu is shown.
To post a comment you must log in.
Revision history for this message
| Ted Gould (ted) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
In silo 13 with a few other changes.