Merge lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data into lp://qastaging/indicator-sound/14.10

Proposed by Ted Gould
Status: Superseded
Proposed branch: lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data
Merge into: lp://qastaging/indicator-sound/14.10
Diff against target: 33 lines (+26/-0)
1 file modified
tests/manual (+26/-0)
To merge this branch: bzr merge lp://qastaging/~ted/indicator-sound/lp1358340-greeter-data
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Antti Kaijanmäki Pending
Review via email: mp+240206@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-09-26.

This proposal has been superseded by a proposal from 2014-10-31.

Commit message

Ensure the greeter menu matches whether song metadata should be shown, and update the metadata based on the new setting.

Description of the change

Listen to the values in accounts service as it's now where all those values are stored. Changes both exporting the song data to AS as well as how our local instance of the greeter menu is shown.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

In silo 13 with a few other changes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote : Posted in a previous version of this proposal

LGTM.

review: Approve

Unmerged revisions

461. By Ted Gould

Test plan test for the greeter mode

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches