Merge lp://qastaging/~ted/indicator-sound/lp1436021-high-volume-warning into lp://qastaging/indicator-sound/15.04
Proposed by
Ted Gould
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Salveti |
| Approved revision: | 489 |
| Merged at revision: | 491 |
| Proposed branch: | lp://qastaging/~ted/indicator-sound/lp1436021-high-volume-warning |
| Merge into: | lp://qastaging/indicator-sound/15.04 |
| Diff against target: |
26 lines (+12/-4) 1 file modified
src/volume-control-pulse.vala (+12/-4) |
| To merge this branch: | bzr merge lp://qastaging/~ted/indicator-sound/lp1436021-high-volume-warning |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Salveti (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Fix stream property lookup to reliably signal multimedia streams
Description of the change
So we were using an index as an index into the stream type array that wasn't really an index of that array. Which means, in a nutshell, it gave really bad results. So most of the time it was infact getting an error condition and returning the default 'alert' instead of which stream was actually being used. So now we use the index on the hash table that it is meant for and reverse out the stream name from there. It makes the high volume warning reliable and actually work. One of those "how did this work at all" type bugs.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:489
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://