Merge lp://qastaging/~ted/indicator-sound/null-selected-user into lp://qastaging/indicator-sound/14.04
Proposed by
Ted Gould
| Status: | Merged |
|---|---|
| Approved by: | Charles Kerr |
| Approved revision: | 439 |
| Merged at revision: | 437 |
| Proposed branch: | lp://qastaging/~ted/indicator-sound/null-selected-user |
| Merge into: | lp://qastaging/indicator-sound/14.04 |
| Prerequisite: | lp://qastaging/~ted/indicator-sound/test-failures |
| Diff against target: |
116 lines (+92/-1) 3 files modified
src/media-player-list-greeter.vala (+1/-1) tests/CMakeLists.txt (+23/-0) tests/greeter-list.cc (+68/-0) |
| To merge this branch: | bzr merge lp://qastaging/~ted/indicator-sound/null-selected-user |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-03-25.
Commit message
Check the username has been gotten before using it.
Description of the change
Seems that in some cases on startup we can get asked for the list of players before we get the information from the greeter on the selected user. Adding a test that fails on trunk, but is fixed by this branch where we test the greeter list with nothing else on DBus so we can ensure it'll never have the username.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:438
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://