Merge lp://qastaging/~ted/indicator-sound/test-failures into lp://qastaging/indicator-sound/14.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 436
Merged at revision: 436
Proposed branch: lp://qastaging/~ted/indicator-sound/test-failures
Merge into: lp://qastaging/indicator-sound/14.04
Diff against target: 21 lines (+2/-2)
1 file modified
tests/media-player-user.cc (+2/-2)
To merge this branch: bzr merge lp://qastaging/~ted/indicator-sound/test-failures
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+212655@code.qastaging.launchpad.net

Commit message

Don't unref the objects in the test

Description of the change

Uhg, not sure why we don't get ref's in these functions, but we don't. Err, vala.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

That must've been a fun one to track down.

The GIcon* returned by g_app_info_get_icon (GAppInfo *appinfo) is [transfer none], so GLib.AppInfo.get_icon()'s return value is unowned.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches