DBus Menu

Merge lp://qastaging/~ted/libdbusmenu/about-to-show-is-activate into lp://qastaging/libdbusmenu/0.5

about-to-show-is-activate
Merge into trunk

Proposed by Ted Gould on 2010-09-17

Status:

Merged

Merged at revision:

163

Proposed branch:

lp://qastaging/~ted/libdbusmenu/about-to-show-is-activate

Merge into:

lp://qastaging/libdbusmenu/0.5

Diff against target:

48 lines (+24/-0)

1 file modified

libdbusmenu-glib/menuitem.c (+24/-0)

To merge this branch:

bzr merge lp://qastaging/~ted/libdbusmenu/about-to-show-is-activate

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
David Barth (community)		2010-09-17	Approve on 2010-09-21
Review via email: mp+35892@code.qastaging.launchpad.net

Description of the change

Making it so that we pass about-to-show up to menu items with children as activate

Revision history for this message

David Barth (dbarth) wrote on 2010-09-20:

What's the rational for not sending activate signals if there are no submenus?

Otherwise looks like what is needed. Glad to see about-to-show connected on the gtk side as well.

Revision history for this message

David Barth (dbarth) wrote on 2010-09-21:

Moving on with the merge proposal: +1, as anyway it's a new feature, so the submenu restriction doesn't impact existing code.

review: Approve

Revision history for this message

Ted Gould (ted) wrote on 2010-09-21:

On Mon, 2010-09-20 at 15:51 +0000, David Barth wrote:
> What's the rational for not sending activate signals if there are no submenus?

Basically because GTK doesn't separate between "about to show" and
"activate." So it seems that some people (Shotwell) are using the
"activate" signal as about-to-show, but in reality if we did that for
other menus items people would be pressing things all over the place :)