libindicator

Merge lp://qastaging/~ted/libindicator/close-signal into lp://qastaging/libindicator/0.4

  1. close-signal
  2. Merge into trunk
Proposed by Ted Gould
Status: Merged
Merged at revision: 391
Proposed branch: lp://qastaging/~ted/libindicator/close-signal
Merge into: lp://qastaging/libindicator/0.4
Diff against target: 0 lines
To merge this branch: bzr merge lp://qastaging/~ted/libindicator/close-signal
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+45651@code.qastaging.launchpad.net

Description of the change

Adding a signal for when the menu is closed. This is useful for XUL based apps and applicaiton indicators.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

How's this a signal? I see you adding a virtual method...

Revision history for this message
Ted Gould (ted) wrote :

On Sun, 2011-01-09 at 22:07 +0000, Mikkel Kamstrup Erlandsen wrote:
> How's this a signal? I see you adding a virtual method...

Well, it's a signal to the indicator that the menu's been closed... so,
not a signal in the programming sense :)

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Ok. The docstring still says indicator_object_entry_activate, you need
to s/activate/closed/. Can you maybe change the wording a bit in the
docs to not say "signal" that confused me a bit - especially since gtk
sometimes leaks signal emitters like this. It's more like a callback
or something.

review: Approve
lp://qastaging/~ted/libindicator/close-signal updated
390. By Ted Gould

Fixing doc strings

Preview Diff

Empty

Subscribers

People subscribed via source and target branches