libindicator

Merge lp://qastaging/~ted/libindicator/gdbus-port into lp://qastaging/libindicator/0.4

  1. gdbus-port
  2. Merge into trunk
Proposed by Ted Gould
Status: Merged
Merged at revision: 390
Proposed branch: lp://qastaging/~ted/libindicator/gdbus-port
Merge into: lp://qastaging/libindicator/0.4
Prerequisite: lp://qastaging/~ted/libindicator/fix-test-suite
Diff against target: 1011 lines (+389/-293)
5 files modified
.bzrignore (+3/-0)
configure.ac (+2/-4)
libindicator/Makefile.am (+12/-14)
libindicator/indicator-service-manager.c (+178/-124)
libindicator/indicator-service.c (+194/-151)
To merge this branch: bzr merge lp://qastaging/~ted/libindicator/gdbus-port
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+45648@code.qastaging.launchpad.net

Description of the change

Oh, we love GDBus even more!

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review needsfixing

In watch_cb() you do g_object_unref(params) but params is a GVariant

If start_service() is called multiple times you seem to be leaking the
proxy in the start_service_cb()?

review: Needs Fixing
Revision history for this message
Ted Gould (ted) wrote :

On Sun, 2011-01-09 at 22:26 +0000, Mikkel Kamstrup Erlandsen wrote:
> In watch_cb() you do g_object_unref(params) but params is a GVariant

Fixed in r410

> If start_service() is called multiple times you seem to be leaking the
> proxy in the start_service_cb()?

Fixed in r411. Using the cancel to detect whether we've already called
it and not doing it again!

lp://qastaging/~ted/libindicator/gdbus-port updated
410. By Ted Gould

Using variant_unref instead of object_unref as it's a variant

411. By Ted Gould

Using the GCancellable to detect if we're already creating a proxy so that we don't do it twice.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Cool. I'm a happy camper :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches