lp://qastaging/~ted/libindicator/lp719457
Created by
Ted Gould
and last modified
- Get this branch:
- bzr branch lp://qastaging/~ted/libindicator/lp719457
Branch merges
Propose for merging
No branches
dependent on this one.
- Charles Kerr (community): Approve
-
Diff: 14 lines (+3/-1)1 file modifiedlibindicator/indicator-service.c (+3/-1)
Related bugs
Bug #719457: valgrind invalid reads error on unloading | Low | Fix Released |
Related blueprints
Branch information
Recent revisions
- 455. By Ted Gould
-
Copying the name before using it to remove as it seems that the unwatch can cause the name to be free'd in some cases. Odd, but valgrind can find it
- 447. By Lars Karlitski
-
indicator_
object_ set_visible: only emit entry-{ added,removed} when visibility actually changed Emitting those signals is semantically incorrect. It also confused
indicator-loader and the panel, because they are not checking whether an entry
is already present in their entry-added handlers. This led to gtk warnings
("widget already has a parent") and strange effects, such as the same menu
being added multiple times into the panel.This patch also makes indicator_
object_ dispose use indicator_ object_ set_visible
(it was already doing something similar).
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/libindicator/0.5