Merge lp://qastaging/~ted/libindicator/unwatching-shouldnt-be-a-crime into lp://qastaging/libindicator/0.4

Proposed by Ted Gould
Status: Merged
Merged at revision: 367
Proposed branch: lp://qastaging/~ted/libindicator/unwatching-shouldnt-be-a-crime
Merge into: lp://qastaging/libindicator/0.4
Diff against target: 365 lines (+273/-4)
7 files modified
.bzrignore (+4/-0)
libindicator/indicator-service.c (+29/-3)
tests/Makefile.am (+54/-0)
tests/service-version-good-service.c (+14/-1)
tests/service-version-multiwatch-manager-impolite.c (+61/-0)
tests/service-version-multiwatch-manager.c (+63/-0)
tests/service-version-multiwatch-service.c (+48/-0)
To merge this branch: bzr merge lp://qastaging/~ted/libindicator/unwatching-shouldnt-be-a-crime
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+29582@code.qastaging.launchpad.net

Description of the change

Fix to not use the proxy when it's being destroyed.

To post a comment you must log in.
371. By Ted Gould

Taking it to the next level with impoliteness.

372. By Ted Gould

We want the key not the value.

Revision history for this message
Jason Smith (jassmith) wrote :

+1 looks good. We should look into if the proxy issue with dispose can be fixed and upstreamed

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches