mediaplayer-app

Merge lp://qastaging/~ted/mediaplayer-app/trusted-session-helper into lp://qastaging/mediaplayer-app

  1. trusted-session-helper
  2. Merge into trunk
Proposed by Ted Gould
Status: Rejected
Rejected by: Ted Gould
Proposed branch: lp://qastaging/~ted/mediaplayer-app/trusted-session-helper
Merge into: lp://qastaging/mediaplayer-app
Diff against target: 155 lines (+34/-42)
7 files modified
CMakeLists.txt (+0/-1)
data/CMakeLists.txt (+0/-11)
data/mediaplayer-app.desktop.in.in (+0/-13)
debian/changelog (+14/-0)
debian/mediaplayer-app.install (+0/-1)
po/CMakeLists.txt (+19/-7)
po/mediaplayer-app.pot (+1/-9)
To merge this branch: bzr merge lp://qastaging/~ted/mediaplayer-app/trusted-session-helper
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+245913@code.qastaging.launchpad.net

Commit message

Convert from an app to a helper

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

O noticed that you have update the pot file to no use the relative path based on pot directory. We did that way because a request from dpm, all our apps use this approach.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

I having a problem testing it I am not sure if this is a camera problem or the url dispatcher one.

On camera roll if you click once nothing happens on the ui saying that the video is going to be played, the user need to wait for about ~3 secs to the mp app to appear. If the user try to click again the mp app will open twice and crash.

Revision history for this message
Ted Gould (ted) wrote :

Updated to remove the changes to the pot file and actually the helper. We moved that into URL dispatcher as that's where it's likely to live long term.

In the future there'll probably be some sort of registration mechanism that mediaplayer will need to use, but we don't have that yet.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:328
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/253/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/847
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/408
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-i386-ci/11
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/740
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/845
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/845/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/333
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/432
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/432/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/253/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This has been long (3 months) in the train spreadsheet with comment "Cleaned, don't believe it is needed right now.". Please add a new landing line if you want to see this landed.

Unmerged revisions

328. By Ted Gould

Change pot file so there's nothing in the diff

327. By Ted Gould

Drop helper dependencies

326. By Ted Gould

Drop the helper from mediaplayer-app

325. By Ted Gould

Adding glib and mir build dependencies

324. By Ted Gould

Merging RTM 14.09 branch

323. By Ted Gould

Fix name of who is connecting

322. By Ted Gould

Add helper to packages

321. By Ted Gould

Flesh out the helper

320. By Ted Gould

Skeleton for the helper

319. By Ted Gould

Adding in a helper directory

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: