Merge lp://qastaging/~ted/ubuntu-touch-session/posix-sequences into lp://qastaging/ubuntu-touch-session

Proposed by Ted Gould
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 245
Merged at revision: 245
Proposed branch: lp://qastaging/~ted/ubuntu-touch-session/posix-sequences
Merge into: lp://qastaging/ubuntu-touch-session
Diff against target: 12 lines (+1/-1)
1 file modified
upstart-session/indicator-sound.override (+1/-1)
To merge this branch: bzr merge lp://qastaging/~ted/ubuntu-touch-session/posix-sequences
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Review via email: mp+244297@code.qastaging.launchpad.net

Commit message

Use a POSIX style sequence instead of a Bash specific one

Description of the change

Uhg, with the other dash was treating it as a string and basically doing the for loop once. Which worked in some cases, but wasn't the behavior we wanted.

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM, tested and was able to get the indicator in time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: