unity-mir

Merge lp://qastaging/~ted/unity-mir/lp1304315-null-terminated-list into lp://qastaging/unity-mir

  1. lp1304315-null-terminated-list
  2. Merge into trunk
Proposed by Ted Gould
Status: Merged
Approved by: Michał Sawicz
Approved revision: 216
Merged at revision: 214
Proposed branch: lp://qastaging/~ted/unity-mir/lp1304315-null-terminated-list
Merge into: lp://qastaging/unity-mir
Diff against target: 25 lines (+4/-3)
1 file modified
src/modules/Unity/Application/upstart/applicationcontroller.cpp (+4/-3)
To merge this branch: bzr merge lp://qastaging/~ted/unity-mir/lp1304315-null-terminated-list
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+216166@code.qastaging.launchpad.net

Commit message

Ensure the last item of the array is NULL

Description of the change

Ensure that the last item is always a NULL. Will happen a lot of the time anyway, but we *really* want to be sure about that.

To post a comment you must log in.
lp://qastaging/~ted/unity-mir/lp1304315-null-terminated-list updated
215. By Ted Gould

Make sure the compiler doesn't free the data as the loop iterates and the bytearray drops out of scope.

216. By Ted Gould

Whitespace

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:216
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/324/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/188
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/188/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/187

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/324/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.
Yes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches