oemedical

Merge lp://qastaging/~the-clone-master/oemedical/oemedical_refactoring_step_I into lp://qastaging/oemedical

  1. oemedical_refactoring_step_I
  2. Merge into trunk
Proposed by Mario Arias
Status: Needs review
Proposed branch: lp://qastaging/~the-clone-master/oemedical/oemedical_refactoring_step_I
Merge into: lp://qastaging/oemedical
Diff against target: 6477 lines (+1028/-4151)
92 files modified
oemedical/__init__.py (+0/-1)
oemedical/__openerp__.py (+9/-42)
oemedical/models/__init__.py (+2/-1)
oemedical/models/oemedical_appointment.py (+20/-21)
oemedical/models/oemedical_patient.py (+21/-20)
oemedical/models/oemedical_physician.py (+63/-8)
oemedical/models/oemedical_specialty.py (+1/-1)
oemedical/models/res_partner.py (+4/-7)
oemedical/oemedical_constants.py.bak (+81/-0)
oemedical/oemedical_invoice/i18n/de.po (+0/-382)
oemedical/oemedical_invoice/i18n/es.po (+0/-374)
oemedical/oemedical_invoice/i18n/it.po (+0/-377)
oemedical/oemedical_invoice/i18n/pt_BR.po (+0/-367)
oemedical/oemedical_invoice/i18n/tr.po (+0/-361)
oemedical/oemedical_invoice/i18n/vi.po (+0/-370)
oemedical/oemedical_menu.xml (+0/-211)
oemedical/oemedical_prescription_order/__init__.py (+0/-25)
oemedical/oemedical_surgery/i18n/ca.po (+0/-144)
oemedical/oemedical_surgery/i18n/de.po (+0/-148)
oemedical/oemedical_surgery/i18n/es.po (+0/-152)
oemedical/oemedical_surgery/i18n/it.po (+0/-152)
oemedical/oemedical_surgery/i18n/pt_BR.po (+0/-152)
oemedical/oemedical_surgery/i18n/tr.po (+0/-141)
oemedical/oemedical_surgery/i18n/vi.po (+0/-149)
oemedical/security/ir.model.access.csv (+85/-8)
oemedical/security/oemedical_security.xml (+34/-4)
oemedical/sequence/oemedical_sequence.xml (+0/-46)
oemedical/views/oemedical_appointment_view.xml (+11/-16)
oemedical/views/oemedical_patient_view.xml (+115/-15)
oemedical/views/oemedical_physician_view.xml (+154/-32)
oemedical/views/res_partner_view.xml (+0/-2)
oemedical_emr/__openerp__.py (+5/-44)
oemedical_emr/models/__init__.py (+2/-0)
oemedical_emr/models/oemedical_diagnostic_hypothesis.py (+0/-1)
oemedical_emr/models/oemedical_directions.py (+0/-1)
oemedical_emr/models/oemedical_disease_group_members.py (+0/-1)
oemedical_emr/models/oemedical_drug_form.py (+1/-2)
oemedical_emr/models/oemedical_drug_route.py (+1/-2)
oemedical_emr/models/oemedical_ethnicity.py (+1/-2)
oemedical_emr/models/oemedical_family.py (+0/-1)
oemedical_emr/models/oemedical_family_member.py (+0/-1)
oemedical_emr/models/oemedical_medicament.py (+0/-1)
oemedical_emr/models/oemedical_medicament_category.py (+0/-1)
oemedical_emr/models/oemedical_medication_dosage.py (+0/-1)
oemedical_emr/models/oemedical_medication_template.py (+0/-1)
oemedical_emr/models/oemedical_occupation.py (+0/-1)
oemedical_emr/models/oemedical_pathology.py (+0/-1)
oemedical_emr/models/oemedical_pathology_category.py (+0/-1)
oemedical_emr/models/oemedical_pathology_group.py (+0/-2)
oemedical_emr/models/oemedical_patient.py (+0/-1)
oemedical_emr/models/oemedical_patient_disease.py (+0/-1)
oemedical_emr/models/oemedical_patient_evaluation.py (+0/-1)
oemedical_emr/models/oemedical_patient_medication.py (+1/-3)
oemedical_emr/models/oemedical_prescription_line.py (+0/-4)
oemedical_emr/models/oemedical_prescription_order.py (+0/-1)
oemedical_emr/models/oemedical_procedure.py (+0/-1)
oemedical_emr/models/oemedical_secondary_condition.py (+0/-1)
oemedical_emr/models/oemedical_signs_and_symptoms.py (+0/-1)
oemedical_emr_data/__openerp__.py (+1/-1)
oemedical_genetics/__openerp__.py (+0/-1)
oemedical_gynecology_and_obstetrics/__openerp__.py (+60/-4)
oemedical_his/__openerp__.py (+1/-2)
oemedical_icu/__openerp__.py (+1/-2)
oemedical_insurance/__init__.py (+1/-1)
oemedical_insurance/__openerp__.py (+1/-2)
oemedical_invoice/models/wizard_appointment_invoice.py (+9/-7)
oemedical_invoice/models/wizard_create_lab_invoice.py (+5/-5)
oemedical_invoice/models/wizard_prescription_invoice.py (+7/-7)
oemedical_lab/__init__.py (+6/-1)
oemedical_lab/__openerp__.py (+1/-2)
oemedical_lifestyle/__openerp__.py (+1/-2)
oemedical_partner_firstname/__init__.py (+20/-0)
oemedical_partner_firstname/__openerp__.py (+40/-0)
oemedical_partner_firstname/i18n/de.po (+31/-0)
oemedical_partner_firstname/i18n/en.po (+32/-0)
oemedical_partner_firstname/i18n/fr.po (+31/-0)
oemedical_partner_firstname/i18n/nl.po (+31/-0)
oemedical_partner_firstname/i18n/partner_firstname.pot (+32/-0)
oemedical_partner_firstname/views/oemedical_patient_view.xml (+32/-0)
oemedical_partner_firstname/views/oemedical_physician_view.xml (+32/-0)
oemedical_pediatrics/__init__.py (+6/-1)
oemedical_pediatrics/__openerp__.py (+1/-2)
oemedical_socioeconomics/__init__.py (+5/-1)
oemedical_socioeconomics/__openerp__.py (+1/-2)
oemedical_surgery/__init__.py (+5/-1)
oemedical_surgery/__openerp__.py (+1/-2)
prescription_order.rml (+0/-279)
web_doc_oemedical/__openerp__.py (+3/-3)
web_doc_oemedical/doc/api_oemedical_index.rst (+6/-3)
web_doc_oemedical/doc/conf.py (+4/-5)
web_doc_oemedical/doc/gyneco.rst (+5/-1)
web_doc_oemedical/doc/index.rst (+5/-7)
To merge this branch: bzr merge lp://qastaging/~the-clone-master/oemedical/oemedical_refactoring_step_I
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Yannick Vaucher @ Camptocamp code review Needs Fixing
Pedro Manuel Baeza Needs Information
Review via email: mp+202240@code.qastaging.launchpad.net

Description of the change

Module re-factoring after split:

* Updated __init__.py and __openerp__.py to allow all modules to be listed in OpenERP without errors.
* Changes to patient, physician and appointment, as well as helper models.
* Finished base classes clean up to comply with new standards (was missing Transient model change...)
* Added oemedical_first_name to allow splitting patient and physician name into first and last name
* Completed clean up of some leftovers from monolithic module structure.
* Changed self.pool.get('model') to new style self.pool['model']
* Defined multi level security roles for physicians, patients, assistants, call center operators, medical center administrators and country level managers.
* Removed class instantiation at the end of the classes, as that is no longer required since v6.1

Community working !! Thanks Nhomar, Pedro and Federico for your tips and changes !!
As an electronics company says.... Everyone is invited!!
Join the party !!

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Mario,

Thanks for your great efforts to bring this project to a usable state. Waiting for a deeper review, I have seen something that flash me and want you to tell: you told about a new module called oemedical_first_name to split personal names in two, but this functionality is already present in module partner_first_name on partner-contact-management OCA repository, so I would prefer to use this module to join efforts in its maintenance and adapt OE to its use when required.

What do you think?

Regards.

review: Needs Information
Reply
Revision history for this message
Mario Arias (the-clone-master) wrote :

Hi Pedro,
In fact it is based on that one.
It just adds inherited fields on new views...

Regards
El 20/01/2014 04:09, "Pedro Manuel Baeza" <email address hidden> escribió:

> Review: Needs Information
>
> Hi, Mario,
>
> Thanks for your great efforts to bring this project to a usable state.
> Waiting for a deeper review, I have seen something that flash me and want
> you to tell: you told about a new module called oemedical_first_name to
> split personal names in two, but this functionality is already present in
> module partner_first_name on partner-contact-management OCA repository, so
> I would prefer to use this module to join efforts in its maintenance and
> adapt OE to its use when required.
>
> What do you think?
>
> Regards.
> --
>
> https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240
> You are the owner of
> lp:~the-clone-master/oemedical/oemedical_refactoring_step_I.
>

Reply
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

l.391 could you search the group with it's xml id group_oemedical_doctor instead of the name ?

Be careful, in xml you have a mix of spaces and tabs keep only spaces.

review: Needs Fixing (code review)
Reply
Revision history for this message
Mario Arias (the-clone-master) wrote :

Hi Yannick,

I will take care of those xml ids and update the MP.

As for spaces and tabs, will check my text editor and adjust accordingly.

Thanks for your time!

Regards,
-Mario

Reply
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

The management of the project has moved to Github: https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed.

Thanks for contributing to the project

review: Needs Resubmitting
Reply

Unmerged revisions

123. By Mario Arias

Merged changes to make all modules listable

122. By Mario Arias

refactoring step 1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.