Merge lp://qastaging/~thedac/charm-helpers/expect-ha into lp://qastaging/charm-helpers
Proposed by
David Ames
Status: | Merged |
---|---|
Merged at revision: | 691 |
Proposed branch: | lp://qastaging/~thedac/charm-helpers/expect-ha |
Merge into: | lp://qastaging/charm-helpers |
Diff against target: |
42 lines (+27/-0) 2 files modified
charmhelpers/contrib/openstack/ha/utils.py (+13/-0) tests/contrib/openstack/ha/test_ha_utils.py (+14/-0) |
To merge this branch: | bzr merge lp://qastaging/~thedac/charm-helpers/expect-ha |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Liam Young (community) | Needs Fixing | ||
Review via email: mp+317402@code.qastaging.launchpad.net |
Description of the change
expect_ha function checks for VIP or dns-ha settings
In OpenStack charms that relate to hacluster it may take time for
hacluster to complete. In the meantime the charm needs a way to be
informed to wait for hacluster. Simply checking for the relation is
too racey. This function checks for tell tale configuration
parameters. The charm can then react accordingly.
Partial-bug: #1661392
To post a comment you must log in.
This fails lint and I think expect_ha could be simplified. I'll put up a mp based on this one so we can get the corresponding charm change landed asap