Merge lp://qastaging/~thedac/charm-helpers/fix-dns into lp://qastaging/charm-helpers
Proposed by
David Ames
| Status: | Merged |
|---|---|
| Merged at revision: | 673 |
| Proposed branch: | lp://qastaging/~thedac/charm-helpers/fix-dns |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
16 lines (+5/-1) 1 file modified
charmhelpers/contrib/network/ip.py (+5/-1) |
| To merge this branch: | bzr merge lp://qastaging/~thedac/charm-helpers/fix-dns |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corey Bryant (community) | Approve | ||
| Marco Ceppi | Approve | ||
|
Review via email:
|
|||
Description of the change
Do not Traceback on failure to resolve DNS
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think we'd want to try to avoid blanket except blocks. Is it possible to add exception handling for the exceptions that are thrown during DNS resolution failures?
otherwise LGTM +1