Merge lp://qastaging/~thedac/charm-helpers/fix-nova-cc-amqp into lp://qastaging/charm-helpers

Proposed by David Ames
Status: Merged
Merged at revision: 695
Proposed branch: lp://qastaging/~thedac/charm-helpers/fix-nova-cc-amqp
Merge into: lp://qastaging/charm-helpers
Diff against target: 96 lines (+10/-9)
2 files modified
charmhelpers/contrib/openstack/context.py (+2/-1)
tests/contrib/openstack/test_os_contexts.py (+8/-8)
To merge this branch: bzr merge lp://qastaging/~thedac/charm-helpers/fix-nova-cc-amqp
Reviewer Review Type Date Requested Status
Alex Kavanagh Approve
Corey Bryant (community) Approve
charmers Pending
Review via email: mp+318129@code.qastaging.launchpad.net

Description of the change

In Ocata nova uses the transport_url for communication to rabbitmq.
In the charm the default port 5672 was assumed. However, when
rabbitmq uses SSL it changes the port to 5671.

This change is the fix which makes the default port explicit and
changes the port when SSL is in use.

To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks! Looks good to me but I can't merge.

review: Approve
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches