Merge lp://qastaging/~thedac/charm-helpers/lp1691881 into lp://qastaging/charm-helpers
Proposed by
David Ames
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 749 | ||||
Proposed branch: | lp://qastaging/~thedac/charm-helpers/lp1691881 | ||||
Merge into: | lp://qastaging/charm-helpers | ||||
Diff against target: |
16 lines (+3/-1) 1 file modified
charmhelpers/contrib/network/ip.py (+3/-1) |
||||
To merge this branch: | bzr merge lp://qastaging/~thedac/charm-helpers/lp1691881 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Kavanagh | Approve | ||
Chris MacNaughton (community) | Approve | ||
Review via email: mp+324891@code.qastaging.launchpad.net |
Description of the change
Decode subprocess output for python3 in ipv6 check
When using python3, the code encounters errors related to type mismatch.
subprocess requires an extra decode of return values to address this.
Partial-Bug: #1691881
To post a comment you must log in.
Looks good to me