Merge lp://qastaging/~thedac/charm-helpers/openstack-workload-status into lp://qastaging/charm-helpers
Proposed by
David Ames
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~thedac/charm-helpers/openstack-workload-status |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
439 lines (+328/-27) 4 files modified
charmhelpers/contrib/openstack/utils.py (+62/-1) charmhelpers/core/hookenv.py (+84/-16) tests/contrib/openstack/test_openstack_utils.py (+43/-0) tests/core/test_hookenv.py (+139/-10) |
| To merge this branch: | bzr merge lp://qastaging/~thedac/charm-helpers/openstack-workload-status |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Page | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Workload status setting decorator and functions based on openstack contexts for openstack charms
Description of the change
Workload status setting decorator and functions based on openstack contexts for openstack charms
To post a comment you must log in.
Unmerged revisions
- 404. By David Ames
-
status_get should always return a dictionary and include-data
Log status change on status set - 403. By David Ames
-
Adapt status_get to allow for --include-data and service
Add status_compound to "add" together statuses
Tests for new features
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
David
I think we need to differentiate between blocked and waiting to provide granualarity to end users - some suggestions in the diff.
Cheers
James