Charm Helpers

Merge lp://qastaging/~thedac/charm-helpers/os-snaps into lp://qastaging/charm-helpers

os-snaps
Merge into devel

Proposed by David Ames on 2017-06-14

Status:	Merged
Merged at revision:	763
Proposed branch:	lp://qastaging/~thedac/charm-helpers/os-snaps
Merge into:	lp://qastaging/charm-helpers
Diff against target:	358 lines (+171/-11) 5 files modified charmhelpers/contrib/openstack/context.py (+6/-0) charmhelpers/contrib/openstack/utils.py (+81/-2) charmhelpers/fetch/snap.py (+6/-0) charmhelpers/fetch/ubuntu.py (+1/-0) tests/contrib/openstack/test_openstack_utils.py (+77/-9)
To merge this branch:	bzr merge lp://qastaging/~thedac/charm-helpers/os-snaps
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Alex Kavanagh	2017-06-14	Approve on 2017-07-13
Corey Bryant (community)		Approve on 2017-07-12
Review via email: mp+325702@code.qastaging.launchpad.net

Description of the change

Helpers for install OpenStack snaps in OpenStack charms

Revision history for this message

Alex Kavanagh (ajkavanagh) wrote on 2017-06-16:

Please see inline comments.

Also, are there no tests for the new functions? I see patches to some of the existing tests for patching out the snaps existence test, but not for the new functions.

(I picked 'needs information' rather than 'needs fixing' because I'm not sure about the design aspect of passing in the post_snap function).

review: Needs Information

lp://qastaging/~thedac/charm-helpers/os-snaps updated on 2017-06-16

754. By Jorge Niedbalski on 2017-06-16: [freyes, r=niedbalski,ajkavanagh] Invoke apt-get only if there
missing packages.
755. By Jorge Niedbalski on 2017-06-16: [freyes,r=niedbalski,ajkavanagh] Fix for test_is_ipv6_disabled.

Revision history for this message

David Ames (thedac) wrote on 2017-06-16:

Alex,

Thanks for your suggestions.

I wrote the unit tests first which made make the changes simpler ;)

Fixed pretty much everything you requested.

lp://qastaging/~thedac/charm-helpers/os-snaps updated on 2017-07-05

756. By Jorge Niedbalski on 2017-06-22: [niedbalski, r=freyes,ajkavanagh] Partial fix required for LP:#1699565.
757. By Jorge Niedbalski on 2017-06-29: [billy-olsen, r=niedbalski] Ensure the config_flags_parser returns an
OrderedDict.
758. By Tim Van Steenburgh on 2017-07-05: v0.17.0

Revision history for this message

Corey Bryant (corey.bryant) wrote on 2017-07-10:

Hi David, I have a few comments below. I think the major thing that is messing things up now is that the current snaps aren't published to a track like they all will be in the future. I'll look into publishing them to the edge channel of the ocata track.

Revision history for this message

David Ames (thedac) wrote on 2017-07-10:

Corey,

I see your point about tracks. Do let me know when you have the snaps published to both the track and the channel and I'll get this MP ready to handle it.

lp://qastaging/~thedac/charm-helpers/os-snaps updated on 2017-07-12

759. By Stuart Bishop on 2017-07-12: [peter-sabaini,r=stub] Helper module for bcache devices

Revision history for this message

David Ames (thedac) wrote on 2017-07-12:

Corey,

I have responded inline on where we are at with your concerns. The next commit fixes the typos.

Revision history for this message

Corey Bryant (corey.bryant) wrote on 2017-07-12:

LGTM. I think we should move ahead with what David has here. Once we get tracks enabled [1] we can land track support in charm-helpers.

[1] https://forum.snapcraft.io/t/track-request-for-openstack-core-snaps/1282

Revision history for this message

Corey Bryant (corey.bryant) on 2017-07-12:

review: Approve

lp://qastaging/~thedac/charm-helpers/os-snaps updated on 2017-07-13

760. By Jorge Niedbalski on 2017-07-12

[freyes, r=niedbalski] Add support to change a user's password in MySQL.

761. By Edward Hope-Morley on 2017-07-13

[zhhuabj,r=ajkavanagh]

When OpenStack clouds get bigger, more messaging transactions
will happen, which will cause more load on rabbitmq server. In
order to mitigate this, polling_interval rpc_response_timeout
and report_interval values are important to adjust accordingly
to the size of OpenStack cluster.

So this patch supports setting those values in neutron-api
centrally, then:

1. polling_interval

   neutron-openvswitch charm gets polling_interval via it's
   relations and set it in [agent] of ml2_conf.ini or
   openvswitch_agent.ini(>=Mitaka)

2. rpc_response_timeout

neutron-gateway charm gets rpc_response_timeout via it's
relations and set it in [default] of neutron.conf

3. report_interval

   Both neutron-openvswitch charm and neutron-gateway charm
   get report_interval via it's relations and set it in
   [agent] of neutron.conf

Thus we need to modifty charm-helpers to also set those values
in NeutronAPIContext.

Related-Bug: 1685788

Revision history for this message

Alex Kavanagh (ajkavanagh) wrote on 2017-07-13:

Looks good. Just a single comment for food for thought in the future.

review: Approve

lp://qastaging/~thedac/charm-helpers/os-snaps updated on 2017-07-18

762. By James Page on 2017-07-18: Fix release name typos in CLOUD_ARCHIVE_POCKETS
763. By David Ames on 2017-07-18: [thedac, r=coreycb,tinwood] OpenStack Charm snap helpers