Merge lp://qastaging/~thekorn/zeitgeist-extensions/geolocation-splitup into lp://qastaging/zeitgeist-extensions
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~thekorn/zeitgeist-extensions/geolocation-splitup |
| Merge into: | lp://qastaging/zeitgeist-extensions |
| Diff against target: |
203 lines (+125/-24) 3 files modified
geolocation/_geolocation.py (+3/-24) geolocation/geolocation_geoclue.py (+52/-0) geolocation/geolocation_maemo.py (+70/-0) |
| To merge this branch: | bzr merge lp://qastaging/~thekorn/zeitgeist-extensions/geolocation-splitup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Seif Lotfy | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch splits the geolocation extension into two parts, the logic which defines the interface and the db structure, and the actual implementations of this extension. Right now there are two implementations, one using Geoclue and the other one using maemo's liblocation.
In order to run this extension copy geolocation/
Unmerged revisions
- 54. By Markus Korn
-
* workaround python-location issue, somehow the 'changed' signal never
arrives
* small fix - 53. By Markus Korn
-
* modified copyright header
* added few logging statements
* first implementation of the maemo version - 52. By Markus Korn
-
* added missing copyright headers
* changed inheritance order. NOTE: this order is important other wise the
the hook methods of Extension will overwrite the implementations of the
extension - 51. By Markus Korn
-
started splitting up the geolocation extension into the logic and an implementation using geoclue as the location provider. Also added the sceleton for the inplementation for maemo
Seems to work fine here. Good Job.