Merge lp://qastaging/~thelinuxguy/openlp/change-dropdown-to-checkbox into lp://qastaging/openlp

Disable means the plugin cannot work due to missing dependencies like Impress or Powerpoint.
Inactive means that the plugin is not to be used i.e you do not want it running in most cases this would be remote.

Looking at the code the combo box needs to support three states not two so this change is not valid as a check box can only have 2 states so this is not a valid change.

The change to about looks valid but why only one plugin why not all of them?

Wew have a test, good but it seems a bit lite!

But the third state doesn't allow the user to change anything.
I guess the third state could be emulated by either disabling the checkbox or replacing it with a label saying it's missing a dependency.

About the change to about:
I only changed about because I was looking for something to test and came across this function.
I can go through the others and change them as well...

about the lite test:
I know it's lite. But I'm not sure what else to test for the about function

No the third state is there because the machine cannot support the plugin, just disabling the check box is not a good indication ofthat state.

and replacing it with a label?

Not in my opinion.

I created a MR for the static methods here: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281488

I just checked, when a plugin is disabled (you can just replace the songs.sqlite with a normal file)
The whole entry becomes disabled. So there really is no reason for the dropdown. Currently the branch throws an Exception when a plugin is disabled, but that can be fixed. What do you think?

Hey Simon, do you want to update your branch and re-propose?

(I mean, merge from trunk)

Great code but we do need a test as all merges require tests.

Sorry.