Notify OSD

Merge lp://qastaging/~themuso/notify-osd/fix-accessibility into lp://qastaging/notify-osd/oneiric

  1. fix-accessibility
  2. Merge into oneiric
Proposed by Luke Yelavich
Status: Merged
Approved by: Mirco Müller
Approved revision: 446
Merge reported by: Mirco Müller
Merged at revision: not available
Proposed branch: lp://qastaging/~themuso/notify-osd/fix-accessibility
Merge into: lp://qastaging/notify-osd/oneiric
Diff against target: 146 lines (+27/-81)
2 files modified
src/bubble-window-accessible.c (+4/-64)
src/bubble-window.c (+23/-17)
To merge this branch: bzr merge lp://qastaging/~themuso/notify-osd/fix-accessibility
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Luke Yelavich (community) Needs Resubmitting
Review via email: mp+83356@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Mostly ok, but please always initialize every variable declared.

122 + AtkRegistry *default_registry = atk_get_default_registry ();
123 + AtkObjectFactory *factory;
124 + AtkObject *accessible;

review: Needs Fixing
lp://qastaging/~themuso/notify-osd/fix-accessibility updated
446. By Luke Yelavich

Initialize declared variables

Revision history for this message
Luke Yelavich (themuso) wrote :

Done.

review: Needs Resubmitting
Revision history for this message
Mirco Müller (macslow) wrote :

All fine now. Passes also "make check" and all stand-alone tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches