OpenERP Community Backports (Web)

Merge lp://qastaging/~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp://qastaging/ocb-web

  1. 7.0_lp1261332_better_report_name
  2. Merge into 7.0
Proposed by Ronald Portier (Therp)
Status: Merged
Merged at revision: 4197
Proposed branch: lp://qastaging/~therp-nl/ocb-web/7.0_lp1261332_better_report_name
Merge into: lp://qastaging/ocb-web
Diff against target: 37 lines (+17/-9)
1 file modified
addons/web/controllers/main.py (+17/-9)
To merge this branch: bzr merge lp://qastaging/~therp-nl/ocb-web/7.0_lp1261332_better_report_name
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp Approve
Lara (Therp) (community) test Approve
Yann Papouin Approve
Pedro Manuel Baeza code review and test Approve
Review via email: mp+219901@code.qastaging.launchpad.net

Description of the change

Port 6.1 proposal to 7.0.

Please ignore the typo in the branchname (1261332 instead of 126322).

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

It works perfectly, and it's a very needed feature.

Thanks for bringing to 7.0.

A non-blocking question is PEP8 issue on l.22.

Regards.

review: Approve (code review and test)
lp://qastaging/~therp-nl/ocb-web/7.0_lp1261332_better_report_name updated
4197. By Ronald Portier (Therp)

[PEP] Slight modification to satisfy pep8 in code generating report filename.

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

Thanks Pedro for the review.

I corrected the pep8 issue (and a trailing whitespace two lines before).

Regards,

Revision history for this message
Yann Papouin (yann-papouin) wrote :

Thanks,
Note that you can easily rename a branch from launchpad.

review: Approve
Revision history for this message
Lara (Therp) (lfreeke) :
review: Approve (test)
Revision history for this message
Yann Papouin (yann-papouin) wrote :

Please do not forgot the MP against official branch

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches