Merge lp://qastaging/~therp-nl/openerp-product-attributes/7-0_fixed_price_extended into lp://qastaging/~product-core-editors/openerp-product-attributes/7.0

Proposed by Ronald Portier (Therp)
Status: Needs review
Proposed branch: lp://qastaging/~therp-nl/openerp-product-attributes/7-0_fixed_price_extended
Merge into: lp://qastaging/~product-core-editors/openerp-product-attributes/7.0
Diff against target: 199 lines (+135/-10)
2 files modified
product_pricelist_fixed_price/model/product_pricelist_item.py (+100/-10)
product_pricelist_fixed_price/view/product_pricelist_item_view.xml (+35/-0)
To merge this branch: bzr merge lp://qastaging/~therp-nl/openerp-product-attributes/7-0_fixed_price_extended
Reviewer Review Type Date Requested Status
Laetitia Gangloff (Acsone) (community) Needs Resubmitting
Product Core Editors Pending
Therp Pending
Serv. Tecnológicos Avanzados - Pedro M. Baeza Pending
Review via email: mp+213378@code.qastaging.launchpad.net

Description of the change

This enhanced fixed pricelist item with the following;

- Make fixed pricelists items work when set through xmlrpc
- Make sure a fixed pricelist item does not have non zero values for rounding, or min. or max. margin
- Make sure a fixed pricelist item refers to a product
- Make fixed price attribute visible in product pricelist item tree view
- Hide all fields that should have non zero values when a pricelist item is set to fixed price.

To post a comment you must log in.
240. By Ronald Portier (Therp)

[FIX] base and base_ext fields should be kept synchronized.
[FIX] base_ext should get correct initial value when module is installed.

241. By Ronald Portier (Therp)

[FIX] Wrong test in check fixed price.

Revision history for this message
Laetitia Gangloff (Acsone) (laetitia-gangloff) wrote :

This project is now hosted on https://github.com/OCA/product-attribute. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

241. By Ronald Portier (Therp)

[FIX] Wrong test in check fixed price.

240. By Ronald Portier (Therp)

[FIX] base and base_ext fields should be kept synchronized.
[FIX] base_ext should get correct initial value when module is installed.

239. By Ronald Portier (Therp)

[FIX] Forgot to make irrelevant fields for fixed prices invisible in form.

238. By Ronald Portier (Therp)

[ENH] Make sure fixed prices have consistent values when set through
    xml-rpc calls.
[ENH] Make sured fixed prices have consistent values when prices had non-zero
    values for rounding or minimum and maximum marges before being changed
    into fixed price.
[ENH] Make fixed price visible in tree view.
[ENH] Make product required for fixed price.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches