desktopcouch

Merge lp://qastaging/~thisfred/desktopcouch/eq_ne into lp://qastaging/desktopcouch

  1. eq_ne
  2. Merge into trunk
Proposed by Eric Casteleijn
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 243
Merged at revision: 252
Proposed branch: lp://qastaging/~thisfred/desktopcouch/eq_ne
Merge into: lp://qastaging/desktopcouch
Diff against target: 56 lines (+35/-0)
2 files modified
desktopcouch/records/__init__.py (+13/-0)
desktopcouch/records/tests/test_record.py (+22/-0)
To merge this branch: bzr merge lp://qastaging/~thisfred/desktopcouch/eq_ne
Reviewer Review Type Date Requested Status
James Tait (community) Approve
Chad Miller (community) Approve
Nicola Larosa Pending
Review via email: mp+45163@code.qastaging.launchpad.net

Commit message

Added __eq__ and __ne__ to MergeableList class so they can be compared to regular lists.

Description of the change

By popular demand: it's now possible to compare mergeable lists to regular list objects (or anything that's a MutableSequence)

To post a comment you must log in.
Revision history for this message
Chad Miller (cmiller) wrote :

Nice! I'd like to see some deeper structure in the tests.

Revision history for this message
Chad Miller (cmiller) :
review: Approve
Revision history for this message
James Tait (jamestait) wrote :

Like Chad, I'd like to see a bit more depth in the tests, but it looks reasonable.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches