desktopcouch

Merge lp://qastaging/~thisfred/desktopcouch/fix-unique-id-test into lp://qastaging/desktopcouch

  1. fix-unique-id-test
  2. Merge into trunk
Proposed by Eric Casteleijn
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 202
Merged at revision: 200
Proposed branch: lp://qastaging/~thisfred/desktopcouch/fix-unique-id-test
Merge into: lp://qastaging/desktopcouch
Diff against target: 444 lines (+128/-90)
2 files modified
desktopcouch/pair/couchdb_pairing/couchdb_io.py (+73/-50)
desktopcouch/pair/tests/test_couchdb_io.py (+55/-40)
To merge this branch: bzr merge lp://qastaging/~thisfred/desktopcouch/fix-unique-id-test
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Vincenzo Di Somma (community) Approve
dobey (community) Approve
Review via email: mp+40461@code.qastaging.launchpad.net

Commit message

This fixes get_my_host_unique_id to pass the context it gets to the methods it calls, so that tests talk to the correct database.

Description of the change

This fixes get_my_host_unique_id to pass the context it gets to the methods it calls, so that tests talk to the correct database.

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1 I like those pylint error out too :)

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

+1

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

me stupid :P, I forgot to approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches