Merge lp://qastaging/~thisfred/desktopcouch/records-records-records-everywhere into lp://qastaging/desktopcouch

Proposed by Eric Casteleijn
Status: Merged
Approved by: John Lenton
Approved revision: 191
Merged at revision: 195
Proposed branch: lp://qastaging/~thisfred/desktopcouch/records-records-records-everywhere
Merge into: lp://qastaging/desktopcouch
Diff against target: 533 lines (+199/-116)
5 files modified
desktopcouch/pair/couchdb_pairing/couchdb_io.py (+24/-22)
desktopcouch/pair/tests/test_couchdb_io.py (+2/-2)
desktopcouch/records/server_base.py (+43/-5)
desktopcouch/records/tests/test_server.py (+125/-79)
desktopcouch/replication_services/ubuntuone.py (+5/-8)
To merge this branch: bzr merge lp://qastaging/~thisfred/desktopcouch/records-records-records-everywhere
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Vincenzo Di Somma (community) Approve
Review via email: mp+39898@code.qastaging.launchpad.net

Commit message

deprecated get_records since it did not return Record objects, and added new method get_all_records that does, in fact, return records

Description of the change

deprecated get_records since it did not return Record objects, and added new method get_all_records that does, in fact, return records

To post a comment you must log in.
Revision history for this message
Vincenzo Di Somma (vds) wrote :

+1

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

finally!

Revision history for this message
dobey (dobey) wrote :

Voting does not meet specified criteria. Required: Approve >= 2, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0. Got: 1 Approve.

Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches