Merge lp://qastaging/~thisfred/ubuntuone-client/add-counter into lp://qastaging/ubuntuone-client

Proposed by Eric Casteleijn
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 1020
Merged at revision: 1045
Proposed branch: lp://qastaging/~thisfred/ubuntuone-client/add-counter
Merge into: lp://qastaging/ubuntuone-client
Diff against target: 333 lines (+109/-57)
6 files modified
tests/platform/linux/test_dbus.py (+22/-0)
tests/platform/linux/test_unity.py (+26/-4)
tests/status/test_aggregator.py (+5/-23)
ubuntuone/platform/linux/dbus_interface.py (+28/-9)
ubuntuone/platform/linux/launcher.py (+28/-8)
ubuntuone/status/aggregator.py (+0/-13)
To merge this branch: bzr merge lp://qastaging/~thisfred/ubuntuone-client/add-counter
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+66050@code.qastaging.launchpad.net

Commit message

* Added a way to set the counter on the launcher icon.
* Added a DBus method for unsetting urgency on the launcher icon, so that only one process needs to ever talk to the launcher (LP: #762722)

Description of the change

* Added a way to set the counter on the launcher icon.
* Added a DBus method for unsetting urgency on the launcher icon, so that only one process needs to ever talk to the launcher (LP: #762722)

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

Looks good to me, but did no field test.

review: Approve
1017. By Eric Casteleijn

remerged trunk

1018. By Eric Casteleijn

reremerged from trunk

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Changed all the setting to set_property, since setting the properties directly does not always work.

1019. By Eric Casteleijn

merged trunk

1020. By Eric Casteleijn

fixed fake launcher and added test for hide_counter

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Code looks good, test passed. Filed bug #806668 regarding some issues that are not related to this branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches