Code review comment for lp://qastaging/~thomas-voss/location-service/fix-1219164

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Addressing the potential race in an update is fine with me, thanks for already filing the bug.

We may wish to reconsider the "<profile> is trying to access your location" string -- while this is nicely unambiguous, it's also going to be incomprehensible for the average user.

Are there human-legible strings that uniquely identify the application? Say, APP_ID and a publisher id?

review: Approve

« Back to merge proposal