Merge lp://qastaging/~thomas-voss/media-hub/add-display-controller-interface into lp://qastaging/media-hub
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~thomas-voss/media-hub/add-display-controller-interface |
| Merge into: | lp://qastaging/media-hub |
| Prerequisite: | lp://qastaging/~thomas-voss/media-hub/refactor-video-sink-interface-to-not-rely-on-hybris-types |
| Diff against target: |
2840 lines (+1594/-805) 24 files modified
include/core/media/service.h (+1/-1) src/core/media/CMakeLists.txt (+9/-1) src/core/media/audio/output_observer.cpp (+43/-0) src/core/media/audio/output_observer.h (+74/-0) src/core/media/audio/pulse_audio_output_observer.cpp (+241/-0) src/core/media/audio/pulse_audio_output_observer.h (+60/-0) src/core/media/dispatcher.h (+38/-0) src/core/media/external_services.h (+83/-0) src/core/media/indicator_power_service.h (+0/-74) src/core/media/player_implementation.cpp (+25/-74) src/core/media/player_implementation.h (+18/-6) src/core/media/power/battery_observer.cpp (+127/-0) src/core/media/power/battery_observer.h (+69/-0) src/core/media/power/state_controller.cpp (+302/-0) src/core/media/power/state_controller.h (+102/-0) src/core/media/powerd_service.h (+0/-73) src/core/media/server/server.cpp (+98/-2) src/core/media/service_implementation.cpp (+111/-446) src/core/media/service_implementation.h (+26/-3) src/core/media/service_stub.h (+3/-1) src/core/media/telephony/call_monitor.cpp (+34/-29) src/core/media/telephony/call_monitor.h (+36/-18) src/core/media/unity_screen_service.h (+0/-72) tests/acceptance-tests/service.cpp (+94/-5) |
| To merge this branch: | bzr merge lp://qastaging/~thomas-voss/media-hub/add-display-controller-interface |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jim Hodapp (community) | code | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Factor out functional dependencies into interfaces and implementations.
Description of the change
Factor out functional dependencies into interfaces and implementations.
Unmerged revisions
- 104. By Thomas Voß
-
Merge prerequisite branch.
- 103. By Thomas Voß
-
* Factor out audio output observation into media::
audio:: OutputObserver. [ Jim Hodapp ]
* Pause playback when a headphone is unplugged or an A2DP device is
unpaired (LP: #1368300)
[ Ricardo Mendoza ]
* Pause playback when a headphone is unplugged or an A2DP device is
unpaired (LP: #1368300) - 102. By Thomas Voß
-
Make ClientDeathObserver instance a dependency passed down through ctors.
- 101. By Thomas Voß
-
Adjust setup of service instance in acceptance tests.
- 100. By Thomas Voß
-
Re-merge prerequisite branch.
- 99. By Thomas Voß
-
Make media::
RecorderObserve r an external dependency. - 98. By Thomas Voß
-
Remerge prerequisite branch.
- 97. By Thomas Voß
-
Put the CallMonitor interface into its own namespace.
- 96. By Thomas Voß
-
Move around implementation.
Remove no longer needed interfaces and implementations. - 95. By Thomas Voß
-
* Refactor client-facing interfaces to pull out explicit dependency on hybris-based media layer.
[ Ubuntu daily release ]
* New rebuild forced
[ Justin McPherson ]
* #1239432 Music fails to pause on incoming/outgoing calls (LP:
#1239432)
[ thomas-voss ]
* Bump build dependency on dbus-cpp to pull in exception safe dtor.
(LP: #1390618)
A lot of code but in general looking good. See my comments inline below. Also, I'd like to see unit tests for all of the new classes that you introduced such as BatteryObserver, StateController, etc.