platform-api

Merge lp://qastaging/~thomas-voss/platform-api/fix-1448180 into lp://qastaging/platform-api/15.04

  1. fix-1448180
  2. Merge into 15.04
Proposed by Thomas Voß
Status: Superseded
Proposed branch: lp://qastaging/~thomas-voss/platform-api/fix-1448180
Merge into: lp://qastaging/platform-api/15.04
Diff against target: 642 lines (+498/-3)
13 files modified
TODO.txt (+1/-0)
debian/control (+1/-1)
include/ubuntu/application/location/CMakeLists.txt (+2/-0)
include/ubuntu/application/location/service.h (+23/-0)
include/ubuntu/application/location/space_vehicle.h (+148/-0)
include/ubuntu/application/location/space_vehicle_update.h (+81/-0)
src/ubuntu/application/common/application/location/CMakeLists.txt (+2/-0)
src/ubuntu/application/common/application/location/instance.h (+30/-1)
src/ubuntu/application/common/application/location/space_vehicle.cpp (+70/-0)
src/ubuntu/application/common/application/location/space_vehicle_p.h (+40/-0)
src/ubuntu/application/common/application/location/space_vehicle_update.cpp (+44/-0)
src/ubuntu/application/common/application/location/space_vehicle_update_p.h (+41/-0)
src/ubuntu/application/ubuntu_application_api.cpp (+15/-1)
To merge this branch: bzr merge lp://qastaging/~thomas-voss/platform-api/fix-1448180
Reviewer Review Type Date Requested Status
Gerry Boland (community) Needs Fixing
Alberto Mardegan (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+274883@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-19.

This proposal has been superseded by a proposal from 2015-12-03.

Commit message

Add reporting of updates to visible space vehicles.

Description of the change

Add reporting of updates to visible space vehicles.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:313
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/444/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/57/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/444/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:314
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/445/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/58/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/445/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:316
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/446/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/59

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/446/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~thomas-voss/platform-api/fix-1448180 updated
317. By Thomas Voß

Wake up jenkins

Revision history for this message
Alberto Mardegan (mardy) wrote :

A few minor nitpicks in the inline comments :-)

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :

+ ua_location_service_set_space_vehicle_update_handler(
How does one unset this? Using null? If so, please document that.

+ ua_location_sapce_vehicle_has_almanac_data(
+ ua_location_sapce_vehicle_has_ephimeris_data(
+ ua_location_sapce_vehicle_is_used_in_fix(
typo

Rest looks ok to me

review: Needs Fixing
lp://qastaging/~thomas-voss/platform-api/fix-1448180 updated
318. By Thomas Voß

Fix typos and document reset of space vehicle update handler.

319. By Thomas Voß

Make sure that required headers are installed.
Make sure that new symbols are actually exposed.

320. By Thomas Voß

Add implementation to test stub.

321. By Thomas Voß

Add functions for subscribing to satellite visibility updates.

322. By Thomas Voß

Bump module versions.

323. By Thomas Voß

Actually implement subscription to space vehicle updates.

324. By Thomas Voß

Revert location-service build-dep to enable dual landings.

325. By Thomas Voß

[ Nick Dedekind ]
* Added api for destroying haptics sensor instance (LP:#1351109)
[ CI Train Bot ]
* debian/libubuntu-application-api3.symbols: update to released
  version.
* No-change rebuild.

326. By Thomas Voß

Merge the other branch again :)

327. By Thomas Voß

#ifdef access to mask pointers.

328. By Thomas Voß

Adjust method signature.

329. By Thomas Voß

[ CI Train Bot ]
* debian/libubuntu-platform-hardware-api3.symbols: update to released
  version.
[ Simon Fels ]
* Workaround API break in Android GPS hardware abstraction API on MTK
  platforms. Each device which need this workaround has to add
[ Thomas Voß ]
* Expose performance boosting capabilities of the underlying
  HW/drivers.

330. By Thomas Voß

Merge lp:~thomas-voss/platform-api/add-missing-functions-to-gps-itf.

Unmerged revisions

330. By Thomas Voß

Merge lp:~thomas-voss/platform-api/add-missing-functions-to-gps-itf.

329. By Thomas Voß

[ CI Train Bot ]
* debian/libubuntu-platform-hardware-api3.symbols: update to released
  version.
[ Simon Fels ]
* Workaround API break in Android GPS hardware abstraction API on MTK
  platforms. Each device which need this workaround has to add
[ Thomas Voß ]
* Expose performance boosting capabilities of the underlying
  HW/drivers.

328. By Thomas Voß

Adjust method signature.

327. By Thomas Voß

#ifdef access to mask pointers.

326. By Thomas Voß

Merge the other branch again :)

325. By Thomas Voß

[ Nick Dedekind ]
* Added api for destroying haptics sensor instance (LP:#1351109)
[ CI Train Bot ]
* debian/libubuntu-application-api3.symbols: update to released
  version.
* No-change rebuild.

324. By Thomas Voß

Revert location-service build-dep to enable dual landings.

323. By Thomas Voß

Actually implement subscription to space vehicle updates.

322. By Thomas Voß

Bump module versions.

321. By Thomas Voß

Add functions for subscribing to satellite visibility updates.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches