Merge lp://qastaging/~thomas-voss/unity-mir/replace_get_env_with_thread_safe_variant into lp://qastaging/unity-mir

Proposed by Thomas Voß
Status: Rejected
Rejected by: Michał Sawicz
Proposed branch: lp://qastaging/~thomas-voss/unity-mir/replace_get_env_with_thread_safe_variant
Merge into: lp://qastaging/unity-mir
Prerequisite: lp://qastaging/~thomas-voss/unity-mir/refactor-oom-score-adj-to-rely-on-process-cpp
Diff against target: 230 lines (+83/-48)
3 files modified
src/modules/Unity/Application/applicationscreenshotprovider.cpp (+14/-12)
src/modules/Unity/Application/taskcontroller.cpp (+63/-29)
src/modules/Unity/Application/ubuntukeyboardinfo.cpp (+6/-7)
To merge this branch: bzr merge lp://qastaging/~thomas-voss/unity-mir/replace_get_env_with_thread_safe_variant
Reviewer Review Type Date Requested Status
Michał Sawicz Disapprove
Gerry Boland (community) Needs Information
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+195037@code.qastaging.launchpad.net

Commit message

Switch to process-cpp for querying the environment in a thread-safe manner.

Description of the change

Switch to process-cpp for querying the environment in a thread-safe manner.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
146. By Thomas Voß

Leverage default values for env::get().

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

As discussed on IRC, posix::this_process::env would give us false confidence that we're safe, when in fact any non-wrapped call to setenv in a library, for example, would result in a segfault just the same.

There's some other changes here that still make sense, please extract them or revert the env-related changes alone.

review: Needs Fixing
147. By Thomas Voß

Merged dependent branches.

148. By Thomas Voß

Reverted changes to getenv.

149. By Thomas Voß

Ensure that panel height is adjusted for grid unit pixel units.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
150. By Thomas Voß

[ Gerry Boland ]
* Unity.Application is not a shared library, but a plugin. (LP:
  #1256014)
* Implement preStart callback added to upstart-app-launch-2. (LP:
  #1243665)
[ Ubuntu daily release ]
* Automatic snapshot from revision 157
[ Gerry Boland ]
* Install ServerStatusListener to be notified of mir server start, pause
  and resume. Use start notification to send SIGSTOP signal to upstart,
  so it knows mir is ready for other clients.
* Bump version number
* InputArea: don't use lambda function as slot, can cause crash on
  shutdown Using lambda function as slot can introduce crash as the
  slot's object deletion is not registered unlike with traditional
  signal/slot connections. As a result, on signal emission, the lambda
  can be called on a deleted object. (LP: #1253685)
* Misc fixes for Mir 0.1.2 support. (LP: #1254986)
[ Alan Griffiths ]
* ApplicationSession is a Mir implementation class that shouldn't be
  used by unity-mir, use shell::session instead.
[ Kevin Gunn ]
* mir server abi and api broke, updating dependency to deb 0.1.1.
* update mir deb build dep to 0.1.2
[ Victor Thompson ]
* Fix mir to not suspend the music-app, or any other app granted a
  lifecycle exception, when switching between apps. (LP: #1241185,
  #1241045)
[ Daniel van Vugt ]
* Force the screen to redraw after turning the display back on (LP:
  #1255045). Also stop the compositor when the screen is off.
  Otherwise it will spin in the background, eating battery. (LP:
  #1255045)
[ Ubuntu daily release ]
* Automatic snapshot from revision 154
* Cherry-pick upstream patch to avoid Unity8 crashing on stop
  (LP: #1253685)
[ Gerry Boland ]
* On MirSurface destruction, any InputAreas on that surface will be
  notified and remove their links to that surface. Fixes crash
  bug:1243444. (LP: #1243444)
[ Alan Griffiths ]
* Remove dependency on mir::shell::SessionManager.
* Remove dependency on mir::surfaces::SurfaceController.
* Remove dependency on msh::OrganisingSurfaceFactory.
* Avoid relying on an explicit Mir typename that changes in a
  refactoring coming soon.
* Do all the hacky surface creation customization in
  SurfaceFactory::create_surface() - and don't mention SurfaceBuilder
  at all. (That will allow Mir to get rid of that interface.).
[ Albert Astals ]
* Don't include the QtQml megaheader Include the one we really need.
[ Ubuntu daily release ]
* Automatic snapshot from revision 144

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Is this MR still relevant?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

No, we've discussed and decided it's a trap.

review: Disapprove

Unmerged revisions

150. By Thomas Voß

[ Gerry Boland ]
* Unity.Application is not a shared library, but a plugin. (LP:
  #1256014)
* Implement preStart callback added to upstart-app-launch-2. (LP:
  #1243665)
[ Ubuntu daily release ]
* Automatic snapshot from revision 157
[ Gerry Boland ]
* Install ServerStatusListener to be notified of mir server start, pause
  and resume. Use start notification to send SIGSTOP signal to upstart,
  so it knows mir is ready for other clients.
* Bump version number
* InputArea: don't use lambda function as slot, can cause crash on
  shutdown Using lambda function as slot can introduce crash as the
  slot's object deletion is not registered unlike with traditional
  signal/slot connections. As a result, on signal emission, the lambda
  can be called on a deleted object. (LP: #1253685)
* Misc fixes for Mir 0.1.2 support. (LP: #1254986)
[ Alan Griffiths ]
* ApplicationSession is a Mir implementation class that shouldn't be
  used by unity-mir, use shell::session instead.
[ Kevin Gunn ]
* mir server abi and api broke, updating dependency to deb 0.1.1.
* update mir deb build dep to 0.1.2
[ Victor Thompson ]
* Fix mir to not suspend the music-app, or any other app granted a
  lifecycle exception, when switching between apps. (LP: #1241185,
  #1241045)
[ Daniel van Vugt ]
* Force the screen to redraw after turning the display back on (LP:
  #1255045). Also stop the compositor when the screen is off.
  Otherwise it will spin in the background, eating battery. (LP:
  #1255045)
[ Ubuntu daily release ]
* Automatic snapshot from revision 154
* Cherry-pick upstream patch to avoid Unity8 crashing on stop
  (LP: #1253685)
[ Gerry Boland ]
* On MirSurface destruction, any InputAreas on that surface will be
  notified and remove their links to that surface. Fixes crash
  bug:1243444. (LP: #1243444)
[ Alan Griffiths ]
* Remove dependency on mir::shell::SessionManager.
* Remove dependency on mir::surfaces::SurfaceController.
* Remove dependency on msh::OrganisingSurfaceFactory.
* Avoid relying on an explicit Mir typename that changes in a
  refactoring coming soon.
* Do all the hacky surface creation customization in
  SurfaceFactory::create_surface() - and don't mention SurfaceBuilder
  at all. (That will allow Mir to get rid of that interface.).
[ Albert Astals ]
* Don't include the QtQml megaheader Include the one we really need.
[ Ubuntu daily release ]
* Automatic snapshot from revision 144

149. By Thomas Voß

Ensure that panel height is adjusted for grid unit pixel units.

148. By Thomas Voß

Reverted changes to getenv.

147. By Thomas Voß

Merged dependent branches.

146. By Thomas Voß

Leverage default values for env::get().

145. By Thomas Voß

Switch to process-cpp for querying the environment in a thread-safe manner.

144. By Thomas Voß

Refactor sigstop'ing and sigcont'ing of application process groups to rely on process-cpp.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches