Merge lp://qastaging/~thomir-deactivatedaccount/unity/fix-launcher-icon-saturations into lp://qastaging/unity
Proposed by
Thomi Richards
| Status: | Merged |
|---|---|
| Approved by: | Thomi Richards |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2221 |
| Proposed branch: | lp://qastaging/~thomir-deactivatedaccount/unity/fix-launcher-icon-saturations |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
84 lines (+45/-4) 2 files modified
plugins/unityshell/src/Launcher.cpp (+7/-4) tests/autopilot/autopilot/tests/test_launcher.py (+38/-0) |
| To merge this branch: | bzr merge lp://qastaging/~thomir-deactivatedaccount/unity/fix-launcher-icon-saturations |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Only desaturate icons when an overlay is shown if the mouse is not over the launcher.
Description of the change
Problem:
Starting the dash with the mouse over the launcher used to desaturate the launcher icons. THis is a bug - icons shouldn't be desaturated if the mouse is over the launcher.
Solution:
Only desaturate icons if the launcher is not under the mouse.
Tests:
Two new autopilot tests. Also moved a previous AP test into the same test class.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good