sademos

Merge lp://qastaging/~thomnico/sademos/juju-on-openstack-resumed into lp://qastaging/sademos/16.04

  1. juju-on-openstack-resumed
  2. Merge into 16.04
Proposed by Nicolas Thomas
Status: Needs review
Proposed branch: lp://qastaging/~thomnico/sademos/juju-on-openstack-resumed
Merge into: lp://qastaging/sademos/16.04
Diff against target: 474 lines (+240/-107)
5 files modified
00-bootstrap.sh (+1/-1)
openstack/01-deploy.sh (+4/-8)
openstack/configure-juju-on-openstack (+106/-51)
openstack/get-cloud-images (+5/-4)
openstack/orange-box-configure-openstack (+124/-43)
To merge this branch: bzr merge lp://qastaging/~thomnico/sademos/juju-on-openstack-resumed
Reviewer Review Type Date Requested Status
CPE SA Pending
Review via email: mp+297745@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
mahmoh (mahmoh) wrote :

Noticed one thing on a quick overview:

openstack/01-deploy.sh:

+juju set-model-config cloudimg-base-url=http://172.27.60.1/mirrors/cloud-images.ubuntu.com/query
31

^static IP, I'm guessing you have OB60?

Note: for grabbing the cloud images from /srv/, definitely the way to go but would be nice to have a checksum check to ensure they were all downloaded properly the first time although testing one's setup would reveal this problem also.

Reply
Revision history for this message
Nicolas Thomas (thomnico) wrote :

Good catch,

It is a remains of the offline work that I plan to provide separately
to avoid a huge review.

Will remove from now

On Fri, Jun 17, 2016 at 3:15 PM, M.Morana <email address hidden> wrote:
> Noticed one thing on a quick overview:
>
> openstack/01-deploy.sh:
>
> +juju set-model-config cloudimg-base-url=http://172.27.60.1/mirrors/cloud-images.ubuntu.com/query
> 31
>
> ^static IP, I'm guessing you have OB60?
>
> Note: for grabbing the cloud images from /srv/, definitely the way to go but would be nice to have a checksum check to ensure they were all downloaded properly the first time although testing one's setup would reveal this problem also.
> --
> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
> You are the owner of lp:~thomnico/sademos/juju-on-openstack-resumed.

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Reply
lp://qastaging/~thomnico/sademos/juju-on-openstack-resumed updated
95. By Nicolas Thomas

Remove the off-line related part.
clean up the code

modified:
  openstack/01-deploy.sh

96. By Nicolas Thomas

Add Xenial to the mix ..

modified:
  openstack/get-cloud-images

Revision history for this message
Scott Croft (secroft) wrote :

Also, with juju 2.0, it's add-model now
On Jun 17, 2016 08:30, "Nicolas Thomas" <email address hidden>
wrote:

> Good catch,
>
> It is a remains of the offline work that I plan to provide separately
> to avoid a huge review.
>
> Will remove from now
>
> On Fri, Jun 17, 2016 at 3:15 PM, M.Morana <email address hidden> wrote:
> > Noticed one thing on a quick overview:
> >
> > openstack/01-deploy.sh:
> >
> > +juju set-model-config cloudimg-base-url=
> http://172.27.60.1/mirrors/cloud-images.ubuntu.com/query
> > 31
> >
> > ^static IP, I'm guessing you have OB60?
> >
> > Note: for grabbing the cloud images from /srv/, definitely the way to go
> but would be nice to have a checksum check to ensure they were all
> downloaded properly the first time although testing one's setup would
> reveal this problem also.
> > --
> >
> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
> > You are the owner of lp:~thomnico/sademos/juju-on-openstack-resumed.
>
>
>
> --
> Best Regards,
> Nicolas Thomas
> http://insights.ubuntu.com/?p=889
> EMEA Solution Architect Canonical
> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9
>
>
> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
> Your team CPE SA is requested to review the proposed merge of
> lp:~thomnico/sademos/juju-on-openstack-resumed into lp:sademos/16.04.
>

Reply
lp://qastaging/~thomnico/sademos/juju-on-openstack-resumed updated
97. By Nicolas Thomas

fix create to add model

Revision history for this message
Nicolas Thomas (thomnico) wrote :

Fixed

Lost in translating to a limited scope ...

On Fri, Jun 17, 2016 at 3:48 PM, Scott Croft <email address hidden> wrote:
> Also, with juju 2.0, it's add-model now
> On Jun 17, 2016 08:30, "Nicolas Thomas" <email address hidden>
> wrote:
>
>> Good catch,
>>
>> It is a remains of the offline work that I plan to provide separately
>> to avoid a huge review.
>>
>> Will remove from now
>>
>> On Fri, Jun 17, 2016 at 3:15 PM, M.Morana <email address hidden> wrote:
>> > Noticed one thing on a quick overview:
>> >
>> > openstack/01-deploy.sh:
>> >
>> > +juju set-model-config cloudimg-base-url=
>> http://172.27.60.1/mirrors/cloud-images.ubuntu.com/query
>> > 31
>> >
>> > ^static IP, I'm guessing you have OB60?
>> >
>> > Note: for grabbing the cloud images from /srv/, definitely the way to go
>> but would be nice to have a checksum check to ensure they were all
>> downloaded properly the first time although testing one's setup would
>> reveal this problem also.
>> > --
>> >
>> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
>> > You are the owner of lp:~thomnico/sademos/juju-on-openstack-resumed.
>>
>>
>>
>> --
>> Best Regards,
>> Nicolas Thomas
>> http://insights.ubuntu.com/?p=889
>> EMEA Solution Architect Canonical
>> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9
>>
>>
>> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
>> Your team CPE SA is requested to review the proposed merge of
>> lp:~thomnico/sademos/juju-on-openstack-resumed into lp:sademos/16.04.
>>
>
> --
> https://code.launchpad.net/~thomnico/sademos/juju-on-openstack-resumed/+merge/297745
> You are the owner of lp:~thomnico/sademos/juju-on-openstack-resumed.

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Reply

Unmerged revisions

97. By Nicolas Thomas

fix create to add model

96. By Nicolas Thomas

Add Xenial to the mix ..

modified:
  openstack/get-cloud-images

95. By Nicolas Thomas

Remove the off-line related part.
clean up the code

modified:
  openstack/01-deploy.sh

94. By Nicolas Thomas

Rework the configure openstack to collect info from juju (no more passwd issues)
Set to use 172.72.(obnum+1) (need the range to be free TBC).
If setting VIP or os-public use it for nova (usefull for 2 network scenario).
Update Windows..

Rename to configure-juju-on-opnestack as it has nothing OB specific .. YES !!
Move to use swift for metadata and generate metadata for images created (juju doc is misleading).

renamed:
  openstack/orange-box-launch-openstack-juju => openstack/configure-juju-on-openstack
modified:
  00-bootstrap.sh
  openstack/01-deploy.sh
  openstack/orange-box-configure-openstack
  openstack/configure-juju-on-openstack

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: