Launchpad itself

Code review comment for lp://qastaging/~thumper/launchpad/set-empty-review-type-as-none

  1. set-empty-review-type-as-none
  2. Merge into devel
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

As said on IRC:

In test_pending_review_registrant it's not super obvious to me that the merge_proposal.registrant is who's passed into nominateReviewer, could you give makeProposalWithReviewer an optional "requester" argument?

All else fine, nice to get this little mystery under control.

« Back to merge proposal