Launchpad itself

Merge lp://qastaging/~thumper/launchpad/strip-email-attachment-path into lp://qastaging/launchpad

strip-email-attachment-path
Merge into devel

Proposed by Tim Penhey on 2011-03-04

Status:

Merged

Approved by:

Robert Collins on 2011-03-06

Approved revision:

no longer in the source branch.

Merged at revision:

12563

Proposed branch:

lp://qastaging/~thumper/launchpad/strip-email-attachment-path

Merge into:

lp://qastaging/launchpad

Diff against target:

66 lines (+30/-1)

2 files modified

lib/canonical/launchpad/database/message.py (+3/-1)
lib/canonical/launchpad/database/tests/test_message.py (+27/-0)

To merge this branch:

bzr merge lp://qastaging/~thumper/launchpad/strip-email-attachment-path

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Robert Collins (community)			Approve on 2011-03-06
Ian Booth (community)	*code	2011-03-04	Approve on 2011-03-04
Review via email: mp+52159@code.qastaging.launchpad.net

Commit message

[r=lifeless,wallyworld][bug=221938] Strip any path information off email attachments when storing in the librarian.

Description of the change

Another relatively trivial email OOPS.

The attachment disposition may specify a path in the filename, but the librarian database table really doesn't like that, so we strip it off.

Revision history for this message

Ian Booth (wallyworld) wrote on 2011-03-04:

Looks good to me. Nice test.

review: Approve (*code)

Revision history for this message

Robert Collins (lifeless) wrote on 2011-03-06:

If you use the fake librarian you can do without the commit() and the test will be faster. This is optional but *highly* recommended.

review: Approve

Revision history for this message

Tim Penhey (thumper) wrote on 2011-03-08:

I got weird failures when attempting to use the fake librarian. Didn't dive too deep as trying to clear current work in progress. Still using the real librarian.