Merge lp://qastaging/~thumper/nux/view-deletion-after-window-thread into lp://qastaging/nux
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Merged at revision: | 485 |
| Proposed branch: | lp://qastaging/~thumper/nux/view-deletion-after-window-thread |
| Merge into: | lp://qastaging/nux |
| Diff against target: |
61 lines (+19/-7) 3 files modified
Nux/Layout.cpp (+5/-2) Nux/View.cpp (+9/-4) NuxGraphics/GLResourceManager.cpp (+5/-1) |
| To merge this branch: | bzr merge lp://qastaging/~thumper/nux/view-deletion-after-window-thread |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jay Taoko (community) | Approve | ||
| Jason Smith (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch changes the hard dependency between views, layouts, resource data and the windows thread.
The view and layout destructors were getting traversing through the windows thread to unregister some internal stuff. However it is possible that the windows thread is destroyed before the views themselves, so they should check before attempting to call through.
The ResourceData class was also trying to go through an object that was in thread local storage. It now checks too.
To post a comment you must log in.
Revision history for this message
| Jay Taoko (jaytaoko) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good