Merge lp://qastaging/~thumper/unity/cleanup-filters into lp://qastaging/unity

Proposed by Tim Penhey
Status: Merged
Merged at revision: 1541
Proposed branch: lp://qastaging/~thumper/unity/cleanup-filters
Merge into: lp://qastaging/unity
Diff against target: 436 lines (+75/-49)
15 files modified
plugins/unityshell/src/FilterBar.cpp (+5/-12)
plugins/unityshell/src/FilterBar.h (+2/-1)
plugins/unityshell/src/FilterExpanderLabel.cpp (+3/-0)
plugins/unityshell/src/FilterExpanderLabel.h (+7/-6)
plugins/unityshell/src/FilterGenreWidget.cpp (+14/-7)
plugins/unityshell/src/FilterGenreWidget.h (+4/-1)
plugins/unityshell/src/FilterMultiRangeWidget.cpp (+5/-5)
plugins/unityshell/src/FilterMultiRangeWidget.h (+4/-1)
plugins/unityshell/src/FilterRatingsWidget.cpp (+5/-2)
plugins/unityshell/src/FilterRatingsWidget.h (+4/-1)
plugins/unityshell/src/FilterWidget.h (+16/-12)
plugins/unityshell/src/PanelIndicatorsView.cpp (+1/-0)
plugins/unityshell/src/PanelIndicatorsView.h (+2/-1)
plugins/unityshell/src/QuicklistMenuItem.cpp (+2/-0)
plugins/unityshell/src/QuicklistMenuItem.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~thumper/unity/cleanup-filters
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Neil J. Patel Pending
Review via email: mp+74952@code.qastaging.launchpad.net

Description of the change

There are two parts to the branch.

The first bit was analysis, where I added missing nux object tracking code
for the type information.

The second bit was the removal of extra references on the layouts in
the filter code, and removing the extra unneeded references on the
buttons.

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

+1 looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.