Merge lp://qastaging/~thumper/unity/decaymulator-destructor into lp://qastaging/unity

Proposed by Tim Penhey
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2162
Proposed branch: lp://qastaging/~thumper/unity/decaymulator-destructor
Merge into: lp://qastaging/unity
Diff against target: 56 lines (+10/-4)
2 files modified
plugins/unityshell/src/Decaymulator.cpp (+8/-3)
plugins/unityshell/src/Decaymulator.h (+2/-1)
To merge this branch: bzr merge lp://qastaging/~thumper/unity/decaymulator-destructor
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+98951@code.qastaging.launchpad.net

Commit message

Make sure the decay function callback is removed on object destruction.

Description of the change

== The problem ==

Unity seg faults if you unplug a monitor while the pointer barrier is still decaying it's values.

== The solution ==

Add a destructor that removes the source if there is one.

== Tests ==

Not really easy to test. Not sure a manual test would help here.

UNBLOCK

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.