Unity

Merge lp://qastaging/~thumper/unity/fix-launcher-multimonitor-resaturate into lp://qastaging/unity

fix-launcher-multimonitor-resaturate
Merge into trunk

Proposed by Tim Penhey on 2012-03-23

Status:

Merged

Approved by:

Tim Penhey on 2012-03-23

Approved revision:

no longer in the source branch.

Merged at revision:

2164

Proposed branch:

lp://qastaging/~thumper/unity/fix-launcher-multimonitor-resaturate

Merge into:

lp://qastaging/unity

Diff against target:

261 lines (+81/-23)

5 files modified

manual-tests/Launcher.txt (+16/-0)
manual-tests/Panel.txt (+14/-0)
plugins/unityshell/src/Launcher.cpp (+19/-4)
plugins/unityshell/src/PanelView.cpp (+30/-18)
plugins/unityshell/src/PanelView.h (+2/-1)

To merge this branch:

bzr merge lp://qastaging/~thumper/unity/fix-launcher-multimonitor-resaturate

Related bugs:

Bug #961844: launcher icons do not re-saturate after dash is closed	High	Fix Released
Bug #962720: Panel goes solid if switching from hud to dash or vice versa	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Thomi Richards (community)		2012-03-23	Approve on 2012-03-23
Review via email: mp+98957@code.qastaging.launchpad.net

Commit message

Make the panel more aware of open overlays, and make sure that all launchers resaturate the icons when overlays (the dash or hud) are closed.

Description of the change

== The problem ==

1. With multiple monitors, closing the hud or dash on one monitor would cause the launcher on one monitor to stay with desaturated icons.

2. The panel would go solid if switching from the hud to the dash (or vice versa) without closing the open overlay first.

== The solution ==

1. A little brutal, but request a redraw when an overlay closes.
2. Remember which overlay last opened, and only go solid if the close matches the last open.

== Tests ==

Manual I'm afraid.

UNBLOCK

Revision history for this message